Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google Big Query Sink Kamelet #849

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Add Google Big Query Sink Kamelet #849

merged 1 commit into from
Mar 25, 2022

Conversation

claudio4j
Copy link
Contributor

@claudio4j claudio4j commented Mar 22, 2022 •
edited
Loading

oscerd
oscerd requested changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking a bit better at this one, the payload in the body should be a map or a list. So I'm not sure this will work out of the box, since sources are not mapping lists or maps directly.

@claudio4j
Copy link
Contributor Author

The kamelet can expect a json as body and I can add a step to transform the json to map or list of map

@oscerd
Copy link
Contributor

oscerd commented Mar 23, 2022

This needs to be documented in the description, because otherwise a user might not know what he has to do.

@claudio4j claudio4j requested a review from oscerd March 23, 2022 22:26
@claudio4j claudio4j force-pushed the add_googlebigquery branch 2 times, most recently from 23621f9 to a0afbe5 Compare March 23, 2022 22:33
oscerd
oscerd requested changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add

  types:
    in:
      mediaType: application/json

@claudio4j claudio4j requested a review from oscerd March 24, 2022 11:35
@oscerd oscerd merged commit 9d6b0d1 into apache:main Mar 25, 2022
@claudio4j claudio4j deleted the add_googlebigquery branch April 4, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@claudio4j @oscerd